Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292313006: Improve activity log ad metrics (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
felt, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve activity log ad metrics - Add metrics for ad injector install location. - Add metrics for injected ad type. - Ignore added elements that have a src of the current page. BUG=357204 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273066

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Adrienne's #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -104 lines) Patch
M chrome/browser/extensions/active_script_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_actions.h View 1 2 3 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_actions.cc View 1 9 chunks +109 lines, -96 lines 0 comments Download
M chrome/browser/extensions/activity_log/uma_policy.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/activity_log/ad_injection/content_script.js View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Devlin
Adrienne, please take a look.
6 years, 7 months ago (2014-05-22 21:43:31 UTC) #1
Devlin
friendly ping
6 years, 7 months ago (2014-05-23 21:19:10 UTC) #2
felt
lgtm with one small nit https://codereview.chromium.org/292313006/diff/20001/chrome/browser/extensions/activity_log/activity_actions.cc File chrome/browser/extensions/activity_log/activity_actions.cc (right): https://codereview.chromium.org/292313006/diff/20001/chrome/browser/extensions/activity_log/activity_actions.cc#newcode125 chrome/browser/extensions/activity_log/activity_actions.cc:125: if (ad_type != AD_TYPE_NONE) ...
6 years, 7 months ago (2014-05-24 00:07:10 UTC) #3
Devlin
https://codereview.chromium.org/292313006/diff/20001/chrome/browser/extensions/activity_log/activity_actions.cc File chrome/browser/extensions/activity_log/activity_actions.cc (right): https://codereview.chromium.org/292313006/diff/20001/chrome/browser/extensions/activity_log/activity_actions.cc#newcode125 chrome/browser/extensions/activity_log/activity_actions.cc:125: if (ad_type != AD_TYPE_NONE) { // All the above ...
6 years, 7 months ago (2014-05-27 16:05:15 UTC) #4
Devlin
Mark, can you take a look at histograms?
6 years, 7 months ago (2014-05-27 16:05:32 UTC) #5
Mark P
one minor comments, otherwise histograms.xml lgtm https://codereview.chromium.org/292313006/diff/40001/chrome/browser/extensions/activity_log/activity_actions.h File chrome/browser/extensions/activity_log/activity_actions.h (right): https://codereview.chromium.org/292313006/diff/40001/chrome/browser/extensions/activity_log/activity_actions.h#newcode69 chrome/browser/extensions/activity_log/activity_actions.h:69: // The type ...
6 years, 7 months ago (2014-05-27 20:07:45 UTC) #6
Devlin
https://codereview.chromium.org/292313006/diff/40001/chrome/browser/extensions/activity_log/activity_actions.h File chrome/browser/extensions/activity_log/activity_actions.h (right): https://codereview.chromium.org/292313006/diff/40001/chrome/browser/extensions/activity_log/activity_actions.h#newcode69 chrome/browser/extensions/activity_log/activity_actions.h:69: // The type of ad which was injected. On ...
6 years, 7 months ago (2014-05-27 20:09:23 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-27 20:09:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/292313006/60001
6 years, 7 months ago (2014-05-27 20:10:36 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 23:15:20 UTC) #10
Message was sent while issue was closed. 
Change committed as 273066

Powered by Google App Engine
This is Rietveld 408576698