Improve activity log ad metrics

chrome/browser/extensions/activity_log/uma_policy.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/uma_policy.h"
 
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/active_script_controller.h"
 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"
 #include "chrome/browser/extensions/activity_log/ad_network_database.h"
 #include "chrome/browser/sessions/session_id.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/common/dom_action_types.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/manifest.h"
 
 namespace extensions {
 
 namespace {
 
 // For convenience.
 const int kNoStatus           = UmaPolicy::NONE;
 const int kContentScript      = 1 << UmaPolicy::CONTENT_SCRIPT;
 const int kReadDom            = 1 << UmaPolicy::READ_DOM;
 const int kModifiedDom        = 1 << UmaPolicy::MODIFIED_DOM;
@@ skipping 156 matching lines @@
       cleaned_url == chrome::kChromeUINewTabURL)
     return;
 
   int statuses[MAX_STATUS - 1];
   std::memset(statuses, 0, sizeof(statuses));
 
   ActiveScriptController* active_script_controller =
       ActiveScriptController::GetForWebContents(web_contents);
   SiteMap::iterator site_lookup = url_status_.find(cleaned_url);
   const ExtensionMap& exts = site_lookup->second;
-  std::vector<std::string> ad_injectors;
+  std::set<std::string> ad_injectors;
   for (ExtensionMap::const_iterator ext_iter = exts.begin();
        ext_iter != exts.end();
        ++ext_iter) {
     if (ext_iter->first == kNumberOfTabs)
       continue;
     for (int i = NONE + 1; i < MAX_STATUS; ++i) {
       if (ext_iter->second & (1 << i))
         statuses[i-1]++;
     }
 
-    if ((ext_iter->second & kAnyAdActivity) && active_script_controller)
-      ad_injectors.push_back(ext_iter->first);
+    if (ext_iter->second & kAnyAdActivity)
+      ad_injectors.insert(ext_iter->first);
   }
   if (active_script_controller)
     active_script_controller->OnAdInjectionDetected(ad_injectors);
 
+  ExtensionRegistry* registry = ExtensionRegistry::Get(profile_);
+  for (std::set<std::string>::const_iterator iter = ad_injectors.begin();
+       iter != ad_injectors.end();
+       ++iter) {
+    const Extension* extension =
+        registry->GetExtensionById(*iter, ExtensionRegistry::EVERYTHING);
+    if (extension) {
+      UMA_HISTOGRAM_ENUMERATION("Extensions.AdInjection.InstallLocation",
+                                extension->location(),
+                                Manifest::NUM_LOCATIONS);
+    }
+  }
+
   std::string prefix = "ExtensionActivity.";
   if (GURL(cleaned_url).host() != "www.google.com") {
     UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(CONTENT_SCRIPT),
                              statuses[CONTENT_SCRIPT - 1]);
     UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(READ_DOM),
                              statuses[READ_DOM - 1]);
     UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(MODIFIED_DOM),
                              statuses[MODIFIED_DOM - 1]);
     UMA_HISTOGRAM_COUNTS_100(prefix + GetHistogramName(DOM_METHOD),
                              statuses[DOM_METHOD - 1]);
@@ skipping 214 matching lines @@
       return "AdLikelyReplaced";
     case NONE:
     case MAX_STATUS:
     default:
       NOTREACHED();
       return "";
   }
 }
 
 }  // namespace extensions