Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2923123005: Log Autofill.Quality.*.ByFieldType by predicted type for unknown data. (Closed)

Created:
3 years, 6 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 6 months ago
Reviewers:
sebsg
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Log Autofill.Quality.*.ByFieldType by predicted type for unknown data. When the actual data type of an field cannot be determined (because it was left empty or was populated with unknown data) log the ByFieldType version of the metrics by the type predicted by autofill. This will allow analysis of the false-positive rate broken down by type. The previous version of the code was logging all of these under Empty/Unknown => AMBIGUOUS. The CL also fleshes out the ByFieldType enumeration in histograms.xml BUG=710474 R=sebsg Review-Url: https://codereview.chromium.org/2870163003 Cr-Original-Commit-Position: refs/heads/master@{#476766} Review-Url: https://codereview.chromium.org/2923123005 . Cr-Commit-Position: refs/branch-heads/3112@{#198} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/a7bf9ee09dc8641a1385ac2c48edfbd6400555f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1239 lines, -811 lines) Patch
M components/autofill/core/browser/autofill_metrics.h View 3 chunks +97 lines, -34 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 5 chunks +212 lines, -50 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 9 chunks +587 lines, -600 lines 0 comments Download
M components/autofill/core/browser/autofill_type.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/field_types.h View 1 chunk +6 lines, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 5 chunks +18 lines, -126 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +226 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 6 chunks +89 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Roger McFarlane (Chromium)
3 years, 6 months ago (2017-06-06 19:15:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7bf9ee09dc8641a1385ac2c48edfbd6400555f8.

Powered by Google App Engine
This is Rietveld 408576698