translate remaining fasta scanner error codes

translate remaining fasta scanner error codes

This updates the fasta scanner to translate the remaining
previously untranslated error codes so that they will be seen
by the analyzer when the fasta scanner is used by analyzer.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/c36936f37f68bfd8eb82dca53eb2fd1a43a5d779

[danrubel, 2017-06-06 02:08:58]

danrubel@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[ahe, 2017-06-06 10:17:17]

lgtm

Subjective (ignorable) nits below.

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_fasta_test.dart (right):

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_fasta_test.dart:214: scanWithListener(r'"${({(}}"',
listener).next as BeginToken;
Use:

BeginToken interpolationStart

and remove cast.

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_fasta_test.dart:254: var openBrace =
scanWithListener('{[(', listener) as BeginToken;
Ditto.

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_replacement_test.dart (right):

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_replacement_test.dart:169: var openBrace =
scanWithListener('{[(<', listener) as analyzer.BeginToken;
Ditto.

[danrubel, 2017-06-06 11:50:41]

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_fasta_test.dart (right):

https://codereview.chromium.org/2923113002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_fasta_test.dart:214: scanWithListener(r'"${({(}}"',
listener).next as BeginToken;
On 2017/06/06 10:17:16, ahe wrote:
> Use:
> 
> BeginToken interpolationStart
> 
> and remove cast.

Good suggestion. Done here and elsewhere in this CL.

[danrubel, 2017-06-06 13:08:17]

Description was changed from

==========
translate remaining fasta scanner error codes

This updates the fasta scanner to translate the remaining
previously untranslated error codes so that they will be seen
by the analyzer when the fasta scanner is used by analyzer.
==========

to

==========
translate remaining fasta scanner error codes

This updates the fasta scanner to translate the remaining
previously untranslated error codes so that they will be seen
by the analyzer when the fasta scanner is used by analyzer.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c36936f37f68bfd8eb82dca53eb2fd1a43a5d779
==========

[danrubel, 2017-06-06 13:08:19]

Committed patchset #2 (id:20001) manually as
c36936f37f68bfd8eb82dca53eb2fd1a43a5d779 (presubmit successful).