translate remaining fasta scanner error codes

pkg/front_end/test/scanner_fasta_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 import 'dart:convert';
 
 import 'package:analyzer/src/fasta/token_utils.dart';
 import 'package:front_end/src/fasta/fasta_codes.dart';
 import 'package:front_end/src/fasta/scanner/error_token.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/string_scanner.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/token.dart' as fasta;
@@ skipping 191 matching lines @@
     }
   }
 
   @override
   void test_mismatched_opener_in_interpolation() {
     // When openers and closers are mismatched,
     // fasta favors considering the opener to be mismatched
     // and inserts synthetic closers as needed.
     // r'"${({(}}"' is parsed as r'"${({()})}"'
     // where both ')' are synthetic
-    var stringStart = _scan(r'"${({(}}"');
-    var interpolationStart = stringStart.next as BeginToken;
+    ErrorListener listener = new ErrorListener();
+    var interpolationStart =
+        scanWithListener(r'"${({(}}"', listener).next as BeginToken;

[ahe, 2017/06/06 10:17:16]

Use:

BeginToken interpolationStart

and remove cast.

[danrubel, 2017/06/06 11:50:41]

Good suggestion. Done here and elsewhere in this CL.

     var openParen1 = interpolationStart.next as BeginToken;
     var openBrace = openParen1.next as BeginToken;
     var openParen2 = openBrace.next as BeginToken;
     var closeParen2 = openParen2.next;
     var closeBrace = closeParen2.next;
     var closeParen1 = closeBrace.next;
     var interpolationEnd = closeParen1.next;
     var stringEnd = interpolationEnd.next;
     expect(stringEnd.next.type, TokenType.EOF);
     expect(interpolationStart.endToken, same(interpolationEnd));
     expect(openParen1.endToken, same(closeParen1));
     expect(openBrace.endToken, same(closeBrace));
     expect(openParen2.endToken, same(closeParen2));
+    listener.assertErrors([
+      new TestError(3, ScannerErrorCode.EXPECTED_TOKEN, [')']),
+      new TestError(5, ScannerErrorCode.EXPECTED_TOKEN, [')']),
+    ]);
   }
 
   void test_next_previous() {
     const source = 'int a; /*1*/ /*2*/ /*3*/ B f(){if (a < 2) {}}';
     Token token =
         new fasta.StringScanner(source, includeComments: true).tokenize();
     while (!token.isEof) {
       expect(token.next.previous, token);
       fasta.CommentToken commentToken = token.precedingComments;
       while (commentToken != null) {
         if (commentToken.next != null) {
           expect(commentToken.next.previous, commentToken);
         }
         commentToken = commentToken.next;
       }
       token = token.next;
     }
   }
 
   @override
   void test_unmatched_openers() {
-    var openBrace = _scan('{[(') as BeginToken;
+    ErrorListener listener = new ErrorListener();
+    var openBrace = scanWithListener('{[(', listener) as BeginToken;

[ahe, 2017/06/06 10:17:16]

Ditto.

     var openBracket = openBrace.next as BeginToken;
     var openParen = openBracket.next as BeginToken;
     var closeParen = openParen.next;
     var closeBracket = closeParen.next;
     var closeBrace = closeBracket.next;
     expect(closeBrace.next.type, TokenType.EOF);
     expect(openBrace.endToken, same(closeBrace));
     expect(openBracket.endToken, same(closeBracket));
     expect(openParen.endToken, same(closeParen));
-  }
-
-  Token _scan(String source,
-      {bool genericMethodComments: false,
-      bool lazyAssignmentOperators: false}) {
-    ErrorListener listener = new ErrorListener();
-    Token token = scanWithListener(source, listener,
-        genericMethodComments: genericMethodComments,
-        lazyAssignmentOperators: lazyAssignmentOperators);
-    listener.assertNoErrors();
-    return token;
+    listener.assertErrors([
+      new TestError(0, ScannerErrorCode.EXPECTED_TOKEN, ['}']),
+      new TestError(1, ScannerErrorCode.EXPECTED_TOKEN, [']']),
+      new TestError(2, ScannerErrorCode.EXPECTED_TOKEN, [')']),
+    ]);
   }
 }
 
 /// Base class for scanner tests that examine the token stream in Fasta format.
 abstract class ScannerTest_Fasta_Base {
   Token scan(String source);
 
   expectToken(Token token, TokenType type, int offset, int length,
       {bool isSynthetic: false, String lexeme}) {
     String description = '${token.type} $token';
@@ skipping 403 matching lines @@
   final ErrorListener _listener;
 
   ToAnalyzerTokenStreamConverter_WithListener(this._listener);
 
   @override
   void reportError(
       ScannerErrorCode errorCode, int offset, List<Object> arguments) {
     _listener.errors.add(new TestError(offset, errorCode, arguments));
   }
 }