third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp - Issue 2923033002: [ActiveSuggestionMarker #2] Add ActiveSuggestionMarker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

Issue 2923033002: [ActiveSuggestionMarker #2] Add ActiveSuggestionMarker (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp b/third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

index 3ed789a82a392b8d7558c9536873ce10fac2ddb1..b80743e5f5873a3d4a5ecb817113f5aaaae27753 100644

--- a/third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

@@ -30,7 +30,8 @@ Color StyleableMarker::BackgroundColor() const {

bool IsStyleableMarker(const DocumentMarker& marker) {

DocumentMarker::MarkerType type = marker.GetType();

- return type == DocumentMarker::kComposition;

+ return type == DocumentMarker::kComposition ||

+ type == DocumentMarker::kActiveSuggestion;

yosin_UTC9 2017/06/06 01:27:48 Could you add a test for IsStylableMaker() with Ac

}

} // namespace blink