third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp - Issue 2923033002: [ActiveSuggestionMarker #2] Add ActiveSuggestionMarker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp

Issue 2923033002: [ActiveSuggestionMarker #2] Add ActiveSuggestionMarker (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/editing/markers/ActiveSuggestionMarker.h ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/editing/markers/StyleableMarker.h"	5 #include "core/editing/markers/StyleableMarker.h"

6	6

7 namespace blink {	7 namespace blink {

8	8

9 StyleableMarker::StyleableMarker(unsigned start_offset,	9 StyleableMarker::StyleableMarker(unsigned start_offset,

10 unsigned end_offset,	10 unsigned end_offset,

(...skipping 12 matching lines...) Expand all Loading...
23 bool StyleableMarker::IsThick() const {	23 bool StyleableMarker::IsThick() const {

24 return thickness_ == Thickness::kThick;	24 return thickness_ == Thickness::kThick;

25 }	25 }

26	26

27 Color StyleableMarker::BackgroundColor() const {	27 Color StyleableMarker::BackgroundColor() const {

28 return background_color_;	28 return background_color_;

29 }	29 }

30	30

31 bool IsStyleableMarker(const DocumentMarker& marker) {	31 bool IsStyleableMarker(const DocumentMarker& marker) {

32 DocumentMarker::MarkerType type = marker.GetType();	32 DocumentMarker::MarkerType type = marker.GetType();

33 return type == DocumentMarker::kComposition;	33 return type == DocumentMarker::kComposition \|\|

	34 type == DocumentMarker::kActiveSuggestion;
	yosin_UTC9 2017/06/06 01:27:48 Could you add a test for IsStylableMaker() with Ac Could you add a test for IsStylableMaker() with ActiveSuggetionMarke?
34 }	35 }

35	36

36 } // namespace blink	37 } // namespace blink

OLD	NEW