Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2923013005: Removed XCallbackParameters and related code. (Closed)

Created:
3 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed XCallbackParameters and related code. XCallbackParameters does not carry anything information that is used and is just passed around the app startup parameters due to legacy reasons. Note that googlechrome-x-callback and chromium-x-callback custom URL schemes are *still supported*. They are parsed and the URL part is extracted for opening in a tab. Review-Url: https://codereview.chromium.org/2923013005 Cr-Commit-Position: refs/heads/master@{#481885} Committed: https://chromium.googlesource.com/chromium/src/+/489d28390c0aee4c59b9c2621bb67930b579d007

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -133 lines) Patch
M ios/chrome/app/chrome_app_startup_parameters.h View 1 chunk +1 line, -4 lines 0 comments Download
M ios/chrome/app/chrome_app_startup_parameters.mm View 1 11 chunks +1 line, -22 lines 0 comments Download
M ios/chrome/app/chrome_app_startup_parameters_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/main_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/app_startup_parameters.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ios/chrome/browser/app_startup_parameters.mm View 3 chunks +3 lines, -18 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
D ios/chrome/browser/xcallback_parameters.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ios/chrome/browser/xcallback_parameters.mm View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pkl (ping after 24h if needed)
lod: who last looked at the app startup parameters stuff. rohitrao: owners & overall
3 years, 6 months ago (2017-06-06 16:03:08 UTC) #2
lody
lgtm
3 years, 6 months ago (2017-06-07 09:54:19 UTC) #3
pkl (ping after 24h if needed)
lod: thank you! rohitrao: ping!
3 years, 6 months ago (2017-06-20 14:24:36 UTC) #4
pkl (ping after 24h if needed)
rohitrao: ping again!
3 years, 6 months ago (2017-06-23 10:37:43 UTC) #5
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-23 11:04:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923013005/1
3 years, 6 months ago (2017-06-23 12:16:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/124252) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-23 12:18:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923013005/20001
3 years, 6 months ago (2017-06-23 12:35:25 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 14:46:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/489d28390c0aee4c59b9c2621bb6...

Powered by Google App Engine
This is Rietveld 408576698