Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2923003002: Settings: About: Fix restart and powerwash button visibility (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Settings: About: Fix restart and powerwash button visibility Currently if |currentChannel_| changes after |targetChannel_| computeShowRelaunchAndPowerwash_() will not get called and the button visibility may be incorrect. Instead of fixing the computeShowRelaunchAndPowerwash_() params, update visibity for both in updateShowRelaunch_() so that they stay in sync. BUG=724518 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916383002 Cr-Original-Commit-Position: refs/heads/master@{#476867} Review-Url: https://codereview.chromium.org/2923003002 . Cr-Commit-Position: refs/branch-heads/3112@{#156} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/a25746de2eb3e28e64aedd114f78902d084b0474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/about_page/about_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
3 years, 6 months ago (2017-06-05 17:26:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a25746de2eb3e28e64aedd114f78902d084b0474.

Powered by Google App Engine
This is Rietveld 408576698