Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: net/disk_cache/simple/simple_version_upgrade.cc

Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases
Patch Set: omewhat better take at higher-level HC::T impl, a bit lessy hacky, and actually write to cache now. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_version_upgrade.cc
diff --git a/net/disk_cache/simple/simple_version_upgrade.cc b/net/disk_cache/simple/simple_version_upgrade.cc
index 1c4a7ba2b2bd569b593d5da059b96c0a0bce0586..b21dbbd22e7fb030649d706e57e23722c51afbff 100644
--- a/net/disk_cache/simple/simple_version_upgrade.cc
+++ b/net/disk_cache/simple/simple_version_upgrade.cc
@@ -198,6 +198,12 @@ bool UpgradeSimpleCacheOnDisk(const base::FilePath& path,
// the V7 index reader is backwards compatible.
version_from++;
}
+
+ if (version_from == 7) {
+ // Likewise, V7 -> V8 is handled entirely by the index reader.
+ version_from++;
+ }
+
DCHECK_EQ(kSimpleVersion, version_from);
if (!new_fake_index_needed)

Powered by Google App Engine
This is Rietveld 408576698