net/disk_cache/simple/simple_synchronous_entry.cc - Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.cc

Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Patch Set: omewhat better take at higher-level HC::T impl, a bit lessy hacky, and actually write to cache now. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_synchronous_entry.cc

diff --git a/net/disk_cache/simple/simple_synchronous_entry.cc b/net/disk_cache/simple/simple_synchronous_entry.cc

index dc27812c71382e95de0430d79a699a080174899d..37459837cc91a1e0f097c888bec62de42fe7ec3e 100644

--- a/net/disk_cache/simple/simple_synchronous_entry.cc

+++ b/net/disk_cache/simple/simple_synchronous_entry.cc

@@ -1499,7 +1499,8 @@ bool SimpleSynchronousEntry::ScanSparseFile(int32_t* out_sparse_data_size) {

return false;

}

- if (header.version != kSimpleVersion) {

+ if (header.version < kLastCompatSparseVersion ||

+ header.version > kSimpleVersion) {

DLOG(WARNING) << "Sparse file unreadable version.";

return false;

}