Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2922883002: Don't move raw pointers in net (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't move raw pointers in net Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=729393 Review-Url: https://codereview.chromium.org/2922883002 Cr-Commit-Position: refs/heads/master@{#476968} Committed: https://chromium.googlesource.com/chromium/src/+/13d0074ae638f5674c784e6568bacf5102d1df98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi Matt, Could you please review? Thanks, Vaclav
3 years, 6 months ago (2017-06-04 17:02:20 UTC) #6
mattm
lgtm
3 years, 6 months ago (2017-06-05 04:00:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922883002/1
3 years, 6 months ago (2017-06-05 10:27:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 10:31:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13d0074ae638f5674c784e6568ba...

Powered by Google App Engine
This is Rietveld 408576698