Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2922813002: [Sync] Using repeated namedspaces in worker unittest. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 6 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Using repeated namedspaces in worker unittest. BUG= Review-Url: https://codereview.chromium.org/2922813002 Cr-Commit-Position: refs/heads/master@{#476816} Committed: https://chromium.googlesource.com/chromium/src/+/13f466e2e115c7554b1522317c16b7e00148fe49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M components/sync/engine_impl/model_type_worker_unittest.cc View 22 chunks +32 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skym
PTAL
3 years, 6 months ago (2017-06-02 21:23:08 UTC) #6
Patrick Noland
lgtm
3 years, 6 months ago (2017-06-02 21:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922813002/1
3 years, 6 months ago (2017-06-02 22:13:17 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 22:19:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13f466e2e115c7554b1522317c16...

Powered by Google App Engine
This is Rietveld 408576698