Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2922763002: [GRC] Fix BUILD.gn for blink. (Closed)

Created:
3 years, 6 months ago by lpy
Modified:
3 years, 6 months ago
CC:
chrome-grc-reviews_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[GRC] Fix BUILD.gn for blink. BUG=691886 Review-Url: https://codereview.chromium.org/2922763002 Cr-Commit-Position: refs/heads/master@{#476755} Committed: https://chromium.googlesource.com/chromium/src/+/617fde26d470b3521f465971163b40566bd28520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M services/resource_coordinator/public/interfaces/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lpy
PTAL.
3 years, 6 months ago (2017-06-02 17:37:00 UTC) #4
oystein (OOO til 10th of July)
lgtm
3 years, 6 months ago (2017-06-02 17:39:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922763002/1
3 years, 6 months ago (2017-06-02 19:29:42 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:35:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/617fde26d470b3521f465971163b...

Powered by Google App Engine
This is Rietveld 408576698