Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2922653003: TabManager: Kill background tabs before android (background) apps. (Closed)

Created:
3 years, 6 months ago by cylee1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, chrome-grc-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TabManager: Kill background tabs before android (background) apps. BUG=chromium:728865 TEST=unit tests Review-Url: https://codereview.chromium.org/2922653003 Cr-Commit-Position: refs/heads/master@{#476663} Committed: https://chromium.googlesource.com/chromium/src/+/32715a644e2054e559a66fbc5d75fc3a75f7a607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resource_coordinator/tab_manager_delegate_chromeos_unittest.cc View 5 chunks +30 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
cylee1
3 years, 6 months ago (2017-06-02 08:40:33 UTC) #2
Yusuke Sato
lgtm
3 years, 6 months ago (2017-06-02 15:20:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922653003/1
3 years, 6 months ago (2017-06-02 15:20:48 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:26:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32715a644e2054e559a66fbc5d75...

Powered by Google App Engine
This is Rietveld 408576698