Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2922653002:
Avoid unnecessary nullptr check. (Closed)
|
Created:
3 years, 6 months ago by Raveendra Karu Modified:
3 years, 6 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid unnecessary nullptr check.
Predictor::InitialObserver::Append() invoked with this pointer
of Predictor class. Hence nullptr check can be removed.
BUG=None
Signed-off-by: Raveendra Karu <r.karu@samsung.com>;
Review-Url: https://codereview.chromium.org/2922653002
Cr-Commit-Position: refs/heads/master@{#476724}
Committed: https://chromium.googlesource.com/chromium/src/+/27ddd073e521f90e7eaed70a383e2397e236d3e4
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
r.karu@samsung.com changed reviewers: + srirama.m@chromium.org, srirama.m@samsung.com
Dear Srirama, Could you please review.
srirama.m@samsung.com changed reviewers: + sky@chromium.org
Peer review looks fine. sky@, please take a look
sky@chromium.org changed reviewers: + mmenke@chromium.org - sky@chromium.org
Please prefer local OWNERs where possible. sky->mmenke
mmenke@chromium.org changed reviewers: + csharrison@chromium.org
[+csharrison]: Don't suppose you have any idea if this is needed or not?
On 2017/06/02 15:58:33, mmenke wrote: > [+csharrison]: Don't suppose you have any idea if this is needed or not? Looks like it's only called in a single place with |this| as an argument, so I don't think it's necessary.
On 2017/06/02 16:01:07, Charlie Harrison wrote: > On 2017/06/02 15:58:33, mmenke wrote: > > [+csharrison]: Don't suppose you have any idea if this is needed or not? > > Looks like it's only called in a single place with |this| as an argument, so I > don't think it's necessary. LGTM, then. (And I've verified Raveendra Karu has signed the CLA)
The CQ bit was checked by r.karu@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by r.karu@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496426858569390, "parent_rev":
"c18f66cce628e31fbde34fa521e526fafeab4839", "commit_rev":
"27ddd073e521f90e7eaed70a383e2397e236d3e4"}
Message was sent while issue was closed.
Description was changed from ========== Avoid unnecessary nullptr check. Predictor::InitialObserver::Append() invoked with this pointer of Predictor class. Hence nullptr check can be removed. BUG=None Signed-off-by: Raveendra Karu <r.karu@samsung.com> ========== to ========== Avoid unnecessary nullptr check. Predictor::InitialObserver::Append() invoked with this pointer of Predictor class. Hence nullptr check can be removed. BUG=None Signed-off-by: Raveendra Karu <r.karu@samsung.com> Review-Url: https://codereview.chromium.org/2922653002 Cr-Commit-Position: refs/heads/master@{#476724} Committed: https://chromium.googlesource.com/chromium/src/+/27ddd073e521f90e7eaed70a383e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/27ddd073e521f90e7eaed70a383e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
