Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2922593002: Move SetSharedWorkerRepositoryClient method from WebFrame to WebLocalFrame. (Closed)

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, dcheng, dglazkov+blink, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SetSharedWorkerRepositoryClient method from WebFrame to WebLocalFrame. The only caller already calls through WebLocalFrame. No intended behavior change. BUG=416660 Review-Url: https://codereview.chromium.org/2922593002 Cr-Commit-Position: refs/heads/master@{#476694} Committed: https://chromium.googlesource.com/chromium/src/+/b7afb6fde379035e430fd960b27f399f9d96b028

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
dcheng@, can you PTAL?
3 years, 6 months ago (2017-06-02 15:56:49 UTC) #6
dcheng
lgtm https://codereview.chromium.org/2922593002/diff/1/third_party/WebKit/public/web/WebLocalFrame.h File third_party/WebKit/public/web/WebLocalFrame.h (right): https://codereview.chromium.org/2922593002/diff/1/third_party/WebKit/public/web/WebLocalFrame.h#newcode115 third_party/WebKit/public/web/WebLocalFrame.h:115: WebSharedWorkerRepositoryClient*) = 0; Thanks for cleaning up the ...
3 years, 6 months ago (2017-06-02 16:32:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922593002/1
3 years, 6 months ago (2017-06-02 16:55:04 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 16:59:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7afb6fde379035e430fd960b27f...

Powered by Google App Engine
This is Rietveld 408576698