Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2922563002: improve handling of missing interpolation identifier (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

improve handling of missing interpolation identifier When the fasta scanner finds a STRING_INTERPOLATION_IDENTIFIER token '$' without an identifier, it now inserts a synthetic identifier R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c4449efa333e2108199668ed69750112c0fd5592

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -82 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 1 chunk +1 line, -2 lines 1 comment Download
M pkg/front_end/test/scanner_fasta_test.dart View 3 chunks +32 lines, -16 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 2 chunks +0 lines, -51 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 3 chunks +62 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 6 months ago (2017-06-01 21:57:05 UTC) #2
scheglov
lgtm
3 years, 6 months ago (2017-06-01 22:02:37 UTC) #3
ahe
lgtm https://codereview.chromium.org/2922563002/diff/1/pkg/front_end/lib/src/fasta/scanner/recover.dart File pkg/front_end/lib/src/fasta/scanner/recover.dart (right): https://codereview.chromium.org/2922563002/diff/1/pkg/front_end/lib/src/fasta/scanner/recover.dart#newcode146 pkg/front_end/lib/src/fasta/scanner/recover.dart:146: return errorTail.next; Wow!
3 years, 6 months ago (2017-06-02 06:29:51 UTC) #4
danrubel
3 years, 6 months ago (2017-06-02 19:16:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4449efa333e2108199668ed69750112c0fd5592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698