Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/front_end/test/scanner_replacement_test.dart

Issue 2922563002: improve handling of missing interpolation identifier (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/scanner_replacement_test.dart
diff --git a/pkg/front_end/test/scanner_replacement_test.dart b/pkg/front_end/test/scanner_replacement_test.dart
index 7a0c815f365d0ebc0a52262da3c522296146846c..aca78d8e75763abe86087b2792443c7f57c4255c 100644
--- a/pkg/front_end/test/scanner_replacement_test.dart
+++ b/pkg/front_end/test/scanner_replacement_test.dart
@@ -124,43 +124,6 @@ class ScannerTest_Replacement extends ScannerTestBase {
}
@override
- void test_mismatched_closer() {
- // When openers and closers are mismatched,
- // fasta favors considering the opener to be mismatched,
- // and inserts synthetic closers as needed.
- // `(])` is parsed as `()])` where the first `)` is synthetic
- // and the trailing `])` are unmatched.
- analyzer.BeginToken openParen = _scan('(])');
- fasta.Token closeParen = openParen.next;
- fasta.Token closeBracket = closeParen.next;
- fasta.Token closeParen2 = closeBracket.next;
- fasta.Token eof = closeParen2.next;
-
- expect(openParen.endToken, same(closeParen));
- expect(closeParen.isSynthetic, isTrue);
- expect(eof.isEof, isTrue);
- }
-
- @override
- void test_mismatched_opener() {
- // When openers and closers are mismatched,
- // fasta favors considering the opener to be mismatched
- // and inserts synthetic closers as needed.
- // `([)` is parsed as `([])` where `]` is synthetic.
- analyzer.BeginToken openParen = _scan('([)');
- analyzer.BeginToken openBracket = openParen.next;
- fasta.Token closeBracket = openBracket.next; // <-- synthetic
- fasta.Token closeParen = closeBracket.next;
- fasta.Token eof = closeParen.next;
-
- expect(openParen.endToken, same(closeParen));
- expect(closeParen.isSynthetic, isFalse);
- expect(openBracket.endToken, same(closeBracket));
- expect(closeBracket.isSynthetic, isTrue);
- expect(eof.isEof, isTrue);
- }
-
- @override
void test_mismatched_opener_in_interpolation() {
// When openers and closers are mismatched,
// fasta favors considering the opener to be mismatched
@@ -191,20 +154,6 @@ class ScannerTest_Replacement extends ScannerTestBase {
}
@override
- @failingTest
- void test_string_simple_interpolation_missingIdentifier() {
- // See defaultRecoveryStrategy recoverStringInterpolation
- super.test_string_simple_interpolation_missingIdentifier();
- }
-
- @override
- @failingTest
- void test_string_simple_interpolation_nonIdentifier() {
- // See defaultRecoveryStrategy recoverStringInterpolation
- super.test_string_simple_interpolation_nonIdentifier();
- }
-
- @override
void test_unmatched_openers() {
// fasta inserts missing closers except for '<'
var openBrace = _scan('{[(<') as analyzer.BeginToken;

Powered by Google App Engine
This is Rietveld 408576698