Generate enum/getters/setters/mappings for image-rendering.

Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

Diff of generated files:
https://gist.github.com/51d00263e744ea52b3b8cc419f54314f/revisions

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2922483004
Cr-Commit-Position: refs/heads/master@{#476585}
Committed: https://chromium.googlesource.com/chromium/src/+/359a15605f7907df8909b75dfac49dfd5d98f6ae

[shend, 2017-06-02 03:07:12]

Description was changed from

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

BUG=628043
==========

to

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[shend, 2017-06-02 03:07:17]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 03:07:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-06-02 03:08:18]

Description was changed from

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

Diff of generated files:
https://gist.github.com/51d00263e744ea52b3b8cc419f54314f/revisions

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[shend, 2017-06-02 03:12:31]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-06-02 03:12:31]

Hi Naina, PTAL

[nainar, 2017-06-02 03:21:36]

lgtm

[shend, 2017-06-02 03:45:57]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-06-02 03:45:58]

Hi Eddy, PTAL

[meade_UTC10, 2017-06-02 04:06:51]

lgtm

[commit-bot: I haz the power, 2017-06-02 05:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 05:37:49]

Dry run: This issue passed the CQ dry run.

[shend, 2017-06-02 05:38:27]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-06-02 05:39:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 05:43:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496381907461160, "parent_rev":
"910c950f0452424597d214b837f31fa99fdc8137", "commit_rev":
"fa3f61334c516cf89137fab45486ebf8f0de2efa"}

[commit-bot: I haz the power, 2017-06-02 05:44:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496381907461160, "parent_rev":
"a1c3d7770142fdf164aa1024c00d7b12226df888", "commit_rev":
"359a15605f7907df8909b75dfac49dfd5d98f6ae"}

[commit-bot: I haz the power, 2017-06-02 05:44:19]

Description was changed from

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

Diff of generated files:
https://gist.github.com/51d00263e744ea52b3b8cc419f54314f/revisions

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Generate enum/getters/setters/mappings for image-rendering.

Currently, the image-rendering property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ImageRendering enum and use the generated
CSSValueID <-> ImageRendering mappings.

We also rename ImageRendering::kOptimizeContrast to
kWebkitOptimizeContrast to match the keywords.

Diff of generated files:
https://gist.github.com/51d00263e744ea52b3b8cc419f54314f/revisions

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2922483004
Cr-Commit-Position: refs/heads/master@{#476585}
Committed:
https://chromium.googlesource.com/chromium/src/+/359a15605f7907df8909b75dfac4...
==========

[commit-bot: I haz the power, 2017-06-02 05:44:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/359a15605f7907df8909b75dfac4...

[eae, 2017-06-14 21:37:21]

Where are all of these auto generated enums defined now? Grepping through the
code base yields nothing and code search can't find them either.
It would be great if we could have the generated file be somewhere discoverable.

Until then, what's the magic header one needs to include to get the definition
of enums like EImageRendering?

[shend, 2017-06-14 22:20:42]

On 2017/06/14 at 21:37:21, eae wrote:
> Where are all of these auto generated enums defined now? Grepping through the
code base yields nothing and code search can't find them either.
> It would be great if we could have the generated file be somewhere
discoverable.
> 
> Until then, what's the magic header one needs to include to get the definition
of enums like EImageRendering?

They should be in out/Debug/gen/blink/core/ComputedStyleBaseConstants.h. It
shows up on code search for me (when I search EImageRendering).

To include that file, you just need to #include
"core/ComputedStyleBaseConstants.h".

[shend, 2017-06-14 22:22:35]

On 2017/06/14 at 22:20:42, shend wrote:
> On 2017/06/14 at 21:37:21, eae wrote:
> > Where are all of these auto generated enums defined now? Grepping through
the code base yields nothing and code search can't find them either.
> > It would be great if we could have the generated file be somewhere
discoverable.
> > 
> > Until then, what's the magic header one needs to include to get the
definition of enums like EImageRendering?
> 
> They should be in out/Debug/gen/blink/core/ComputedStyleBaseConstants.h. It
shows up on code search for me (when I search EImageRendering).
> 
> To include that file, you just need to #include
"core/ComputedStyleBaseConstants.h".

Actually, it's better to #include "core/style/ComputedStyleConstants.h", which
has both handwritten and generated enums.

[nainar, 2017-06-14 23:10:56]

On 2017/06/14 at 22:22:35, shend wrote:
> On 2017/06/14 at 22:20:42, shend wrote:
> > On 2017/06/14 at 21:37:21, eae wrote:
> > > Where are all of these auto generated enums defined now? Grepping through
the code base yields nothing and code search can't find them either.
> > > It would be great if we could have the generated file be somewhere
discoverable.
> > > 
> > > Until then, what's the magic header one needs to include to get the
definition of enums like EImageRendering?
> > 
> > They should be in out/Debug/gen/blink/core/ComputedStyleBaseConstants.h. It
shows up on code search for me (when I search EImageRendering).
> > 
> > To include that file, you just need to #include
"core/ComputedStyleBaseConstants.h".
> 
> Actually, it's better to #include "core/style/ComputedStyleConstants.h", which
has both handwritten and generated enums.

Hi eae@, 

You are right pushing the code into out/Debug/gen/blink/core/ does reduce its
discoverability. Specifically if you are grepping in Source/core. We can't push
the generated files into Source/core because gn specifically prohibits it.
shend@ is reaching out to the gn folks to see if there is a workaround. In the
meanwhile, we will add a comment to all the handwritten files specifying where
you can find the corresponding generated code. This doesn't solve the grepping
problem, but hopefully makes is that 10% easier to find what you are looking
for.