Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2922483002: [WebPayments] Making all fields and buttons focusable (Closed)

Created:
3 years, 6 months ago by tmartino
Modified:
3 years, 6 months ago
Reviewers:
Mathieu, anthonyvd
CC:
chromium-reviews, Mathieu, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebPayments] Making all fields and buttons focusable BUG=717322 Review-Url: https://codereview.chromium.org/2922483002 Cr-Commit-Position: refs/heads/master@{#476656} Committed: https://chromium.googlesource.com/chromium/src/+/dba5a604232cfd14f6c0d4f6ea04ba38b8fe89c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/profile_list_view_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/validating_combobox.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tmartino
3 years, 6 months ago (2017-06-01 17:51:20 UTC) #6
anthonyvd
lgtm
3 years, 6 months ago (2017-06-02 13:19:36 UTC) #7
Mathieu
Can you add a bug number and target it to M-60, because we will likely ...
3 years, 6 months ago (2017-06-02 13:22:27 UTC) #9
anthonyvd
On 2017/06/02 at 13:22:27, mathp wrote: > Can you add a bug number and target ...
3 years, 6 months ago (2017-06-02 13:23:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922483002/1
3 years, 6 months ago (2017-06-02 15:12:44 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:16:42 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dba5a604232cfd14f6c0d4f6ea04...

Powered by Google App Engine
This is Rietveld 408576698