Replace deprecated base::NonThreadSafe in ui\gfx\image_skia.cc in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in ui\gfx\image_skia.cc in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   ImageSkiaStorage doesn't appear thread-affine so that's most likely
   a no-op.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~SequenceChecker() doesn't by design. Hence this CL allows
   removing the explicit Detach from ~ImageSkiaStorage().

BUG=676387
Review-Url: https://codereview.chromium.org/2922463002
Cr-Commit-Position: refs/heads/master@{#476727}
Committed: https://chromium.googlesource.com/chromium/src/+/728abbb55ee7c2da5819b56c22bbedd79fb0e09b

[gab, 2017-06-01 14:37:22]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 14:37:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-01 14:38:41]

gab@chromium.org changed reviewers:
+ oshima@chromium.org

[gab, 2017-06-01 14:38:42]

@oshima PTaL, thanks!

[commit-bot: I haz the power, 2017-06-01 15:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:51:07]

Dry run: This issue passed the CQ dry run.

[gab, 2017-06-02 14:37:49]

On 2017/06/01 14:38:42, gab wrote:
> @oshima PTaL, thanks!

friendly ping, one of the last blockers to get rid of base::NonThreadSafe
entirely =P!

[oshima, 2017-06-02 17:01:19]

lgtm

[gab, 2017-06-02 17:05:27]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:05:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:17:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496423127657840, "parent_rev":
"f7dcd7b3aa7133e6db29e5d900b472d3b2368718", "commit_rev":
"728abbb55ee7c2da5819b56c22bbedd79fb0e09b"}

[commit-bot: I haz the power, 2017-06-02 18:17:26]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in ui\gfx\image_skia.cc in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   ImageSkiaStorage doesn't appear thread-affine so that's most likely
   a no-op.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~SequenceChecker() doesn't by design. Hence this CL allows
   removing the explicit Detach from ~ImageSkiaStorage().

BUG=676387
==========

to

==========
Replace deprecated base::NonThreadSafe in ui\gfx\image_skia.cc in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   ImageSkiaStorage doesn't appear thread-affine so that's most likely
   a no-op.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~SequenceChecker() doesn't by design. Hence this CL allows
   removing the explicit Detach from ~ImageSkiaStorage().

BUG=676387

Review-Url: https://codereview.chromium.org/2922463002
Cr-Commit-Position: refs/heads/master@{#476727}
Committed:
https://chromium.googlesource.com/chromium/src/+/728abbb55ee7c2da5819b56c22bb...
==========

[commit-bot: I haz the power, 2017-06-02 18:17:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/728abbb55ee7c2da5819b56c22bb...