Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2922423002: Remove NSSCryptoModuleDelegate. (Closed)

Created:
3 years, 6 months ago by davidben
Modified:
3 years, 6 months ago
Reviewers:
sky, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NSSCryptoModuleDelegate. This is no longer used now that <keygen> is gone. BUG= Review-Url: https://codereview.chromium.org/2922423002 Cr-Commit-Position: refs/heads/master@{#478085} Committed: https://chromium.googlesource.com/chromium/src/+/08465dd44a9546be7d8fc87f0e1b9c00413cfedf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -129 lines) Patch
M chrome/browser/net/nss_context.h View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/net/nss_context_chromeos.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/net/nss_context_linux.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/crypto_module_delegate_nss.h View 2 chunks +2 lines, -24 lines 0 comments Download
M chrome/browser/ui/crypto_module_delegate_nss.cc View 2 chunks +3 lines, -52 lines 0 comments Download
M crypto/nss_crypto_module_delegate.h View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
davidben
BTW, I noticed this as I was reviewing your CL. (Feel free to tell me ...
3 years, 6 months ago (2017-06-07 23:34:44 UTC) #6
mattm
lgtm! I'm fine with doing the merge, and it'll even slightly reduce the size of ...
3 years, 6 months ago (2017-06-08 00:34:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922423002/1
3 years, 6 months ago (2017-06-08 16:07:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/459084)
3 years, 6 months ago (2017-06-08 16:17:54 UTC) #11
davidben
+sky for chrome/browser/ui OWNERS
3 years, 6 months ago (2017-06-08 16:19:21 UTC) #13
sky
LGTM
3 years, 6 months ago (2017-06-08 21:00:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922423002/1
3 years, 6 months ago (2017-06-08 21:06:14 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:11:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08465dd44a9546be7d8fc87f0e1b...

Powered by Google App Engine
This is Rietveld 408576698