Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2922353002: Support reading a binary file as ArrayBuffer (Closed)

Created:
3 years, 6 months ago by smvv
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Support reading a binary file as ArrayBuffer Calling `read(filename, 'binary')` should return an ArrayBuffer like SpiderMonkey does. It is possible to call `readbuffer` instead, but that function is not available in the SpiderMonkey JS shell. BUG=v8:6464 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2922353002 Cr-Commit-Position: refs/heads/master@{#45776} Committed: https://chromium.googlesource.com/v8/v8/+/e285b7122083faca437b932ed0f570a358e11af7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/d8.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
smvv
3 years, 6 months ago (2017-06-06 12:10:22 UTC) #1
bradnelson
I need to sync with folks here if this ok. But offhand seems so. Will ...
3 years, 6 months ago (2017-06-07 14:56:21 UTC) #2
bradnelson
lgtm, but would also bmeurer's signoff.
3 years, 6 months ago (2017-06-07 16:11:46 UTC) #5
Benedikt Meurer
LGTM!
3 years, 6 months ago (2017-06-07 16:33:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922353002/1
3 years, 6 months ago (2017-06-07 16:43:46 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 17:11:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e285b7122083faca437b932ed0f570a358e...

Powered by Google App Engine
This is Rietveld 408576698