cros: Run telemetry tests on mojo-cros fyi bot.

cros: Run telemetry tests on mojo-cros fyi bot.

Run telemetry_perf_unittests and telemetry_unittests on mojo-cros fyi
bot.

BUG=704681
Review-Url: https://codereview.chromium.org/2922333002
Cr-Commit-Position: refs/heads/master@{#478305}
Committed: https://chromium.googlesource.com/chromium/src/+/019bf69cc182113a1512ed0b57adca8aa59bf59c

[sadrul, 2017-06-06 07:22:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 07:22:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-06-06 07:26:45]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 07:26:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 07:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 07:31:26]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-06-06 13:07:32]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 13:07:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 15:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 15:59:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-06-06 17:14:49]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 17:15:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 20:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 20:10:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-06-07 02:36:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 02:36:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 03:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 03:33:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-06-07 03:41:48]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 03:42:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-06-07 04:25:07]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 04:25:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 05:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 05:26:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-06-07 22:16:57]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:17:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-06-07 22:17:50]

Description was changed from

==========
[exp] cros: Run telemetry_perf_unittests on mojo-cros fyi bots.

...

BUG=...
==========

to

==========
cros: Run telemetry tests on mojo-cros fyi bot.

Run telemetry_perf_unittests and telemetry_unittests on mojo-cros fyi
bot.

BUG=704681
==========

[sadrul, 2017-06-07 22:20:37]

sadrul@chromium.org changed reviewers:
+ dpranke@chromium.org, sky@chromium.org

[sadrul, 2017-06-07 22:20:38]

Patchset 7 has the tests running in the trybot too. You will notice that
telemetry_perf_unittests passed on the linux_chromium_chromeos_ozone_rel_ng
trybot, but a few tests in telemetry_unittests failed.
https://codereview.chromium.org/2920223010/ should fix those failures. But these
tests are going to run only on the fyi bot for now.

[sky, 2017-06-07 23:14:43]

LGTM - but wait for Dirk.

[Dirk Pranke, 2017-06-07 23:30:23]

I hate to say it, but this CL is confusing to me.

Why are there now two stub executables in this config, and why are we running
test_chrome instead of chrome? Why aren't we just adding the data deps to the
chrome_initial binary instead?

I'm guessing you actually want to be able to test both configurations in a
single build?

It strikes me as confusing that telemetry_perf_unittests would run 'test_chrome'
instead of 'chrome' in *just this configuration*, and yet we'd call it the same
thing instead of something like 'mash_telemetry_perf_unittests' or some such.

Does that make sense, or am I off base here?

[sadrul, 2017-06-07 23:37:47]

On 2017/06/07 23:30:23, Dirk Pranke wrote:
> I hate to say it, but this CL is confusing to me.
> 
> Why are there now two stub executables in this config, and why are we running
> test_chrome instead of chrome? Why aren't we just adding the data deps to the
> chrome_initial binary instead?
> 
> I'm guessing you actually want to be able to test both configurations in a
> single build?
> 
> It strikes me as confusing that telemetry_perf_unittests would run
'test_chrome'
> instead of 'chrome' in *just this configuration*, and yet we'd call it the
same
> thing instead of something like 'mash_telemetry_perf_unittests' or some such.
> 
> Does that make sense, or am I off base here?

test_chrome is chrome, with access to some test apis that we do not want to leak
into the main chrome binary. We are using this binary in non mus/mash cases too.
For mus/mash, we would need to add additional flags. So to me, it makes sense to
call these telemetry_* tests, and the ones with those additional flags would be
called mus_telemetry_* etc tests.

[commit-bot: I haz the power, 2017-06-07 23:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 23:41:14]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-06-09 03:40:53]

ok. lgtm :).

[sadrul, 2017-06-09 15:09:42]

On 2017/06/09 03:40:53, Dirk Pranke wrote:
> ok. lgtm :).

Thanks!

[sadrul, 2017-06-09 15:09:48]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-06-09 15:09:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 16:41:21]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497020988457160,
"parent_rev": "c390948c4980dd2a6afcc2cbc0775c38ff4c25f8", "commit_rev":
"019bf69cc182113a1512ed0b57adca8aa59bf59c"}

[commit-bot: I haz the power, 2017-06-09 16:41:33]

Description was changed from

==========
cros: Run telemetry tests on mojo-cros fyi bot.

Run telemetry_perf_unittests and telemetry_unittests on mojo-cros fyi
bot.

BUG=704681
==========

to

==========
cros: Run telemetry tests on mojo-cros fyi bot.

Run telemetry_perf_unittests and telemetry_unittests on mojo-cros fyi
bot.

BUG=704681

Review-Url: https://codereview.chromium.org/2922333002
Cr-Commit-Position: refs/heads/master@{#478305}
Committed:
https://chromium.googlesource.com/chromium/src/+/019bf69cc182113a1512ed0b57ad...
==========

[commit-bot: I haz the power, 2017-06-09 16:41:39]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/019bf69cc182113a1512ed0b57ad...