JDA unittest: don't require the test file in /media/test/data/.

JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2922323003
Cr-Commit-Position: refs/heads/master@{#479671}
Committed: https://chromium.googlesource.com/chromium/src/+/dc3a1ab1e79d4d5dced497aaabd8aab9cbabcd67

[mojahsu1, 2017-06-07 03:11:47]

Description was changed from

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
==========

to

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mojahsu1, 2017-06-07 06:39:56]

Description was changed from

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mojahsu1, 2017-06-07 06:39:56]

mojahsu@chromium.org changed reviewers:
+ henryhsu@chromium.org, wuchengli@chromium.org

[wuchengli, 2017-06-08 02:44:32]

https://codereview.chromium.org/2922323003/diff/1/media/base/test_data_util.cc
File media/base/test_data_util.cc (right):

https://codereview.chromium.org/2922323003/diff/1/media/base/test_data_util.c...
media/base/test_data_util.cc:41: base::FilePath
GetOriginalOrTestDataFilePath(const std::string& name) {
It doesn't look like this class needs to provide this functionality. This is a
bit specific. Doing it in jpeg_decode_accelerator_unittest is enough.

[mojahsu1, 2017-06-12 07:29:45]

https://codereview.chromium.org/2922323003/diff/1/media/base/test_data_util.cc
File media/base/test_data_util.cc (right):

https://codereview.chromium.org/2922323003/diff/1/media/base/test_data_util.c...
media/base/test_data_util.cc:41: base::FilePath
GetOriginalOrTestDataFilePath(const std::string& name) {
On 2017/06/08 02:44:32, wuchengli wrote:
> It doesn't look like this class needs to provide this functionality. This is a
> bit specific. Doing it in jpeg_decode_accelerator_unittest is enough.

Done.

[wuchengli, 2017-06-12 07:42:42]

lgtm

[henryhsu, 2017-06-12 07:58:45]

https://codereview.chromium.org/2922323003/diff/20001/media/gpu/jpeg_decode_a...
File media/gpu/jpeg_decode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2922323003/diff/20001/media/gpu/jpeg_decode_a...
media/gpu/jpeg_decode_accelerator_unittest.cc:439: return
GetTestDataFilePath(name);
how about print the final path to know the path we are using?

[mojahsu1, 2017-06-14 06:49:12]

https://codereview.chromium.org/2922323003/diff/20001/media/gpu/jpeg_decode_a...
File media/gpu/jpeg_decode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2922323003/diff/20001/media/gpu/jpeg_decode_a...
media/gpu/jpeg_decode_accelerator_unittest.cc:439: return
GetTestDataFilePath(name);
On 2017/06/12 07:58:45, henryhsu wrote:
> how about print the final path to know the path we are using?

Done.

[henryhsu, 2017-06-15 07:21:27]

On 2017/06/14 06:49:13, mojahsu1 wrote:

lgtm

[mojahsu, 2017-06-15 09:23:55]

The CQ bit was checked by mojahsu@google.com

[mojahsu, 2017-06-15 09:23:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
wuchengli@chromium.org
Link to the patchset: https://codereview.chromium.org/2922323003/#ps40001
(title: "JDA unittest: don't require the test file in /media/test/data/.")

[commit-bot: I haz the power, 2017-06-15 09:24:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 11:58:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497518635632220,
"parent_rev": "a582bda6805aebbb9cc2e3d360aea2e7e9522161", "commit_rev":
"dc3a1ab1e79d4d5dced497aaabd8aab9cbabcd67"}

[commit-bot: I haz the power, 2017-06-15 11:58:36]

Description was changed from

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
JDA unittest: don't require the test file in /media/test/data/.

The test expected the jpeg to be in /media/test/data. Let it can get
jpeg file from both original file path or under /media/test/data path.

BUG=700782
TEST=Run JDA unittest on elm with test file in local directory or
/media/test/data directory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2922323003
Cr-Commit-Position: refs/heads/master@{#479671}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc3a1ab1e79d4d5dced497aaabd8...
==========

[commit-bot: I haz the power, 2017-06-15 11:58:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc3a1ab1e79d4d5dced497aaabd8...