Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2922283002: [Merge to M60] Keep the wrapper of FetchEvent alive while waiting for the preload response. (Closed)

Created:
3 years, 6 months ago by horo
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge to M60] Keep the wrapper of FetchEvent alive while waiting for the preload response. This CL uses ActiveScriptWrappable and implements HasPendingActivity() to keep the wrapper of FetchEvent alive while waiting for the preload response. FetchEvents are already kept alive by ServiceWorkerGlobalScopeProxy's |pending_preload_fetch_events_| until the preload response. But the resolver function is not called in the current implementation if GC happens. (https://crbug.com/728013#c28) That is because if the wrapper of FetchEvent are GCed, ScriptPromiseProperty can't call the resolver. BUG=728013 Review-Url: https://codereview.chromium.org/2922863002 Cr-Original-Commit-Position: refs/heads/master@{#476977} Review-Url: https://codereview.chromium.org/2922283002 . Cr-Commit-Position: refs/branch-heads/3112@{#174} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/50e7718fc9bc2d63c3c8a69de2a25864b970ba0b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
horo
3 years, 6 months ago (2017-06-06 00:15:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50e7718fc9bc2d63c3c8a69de2a25864b970ba0b.

Powered by Google App Engine
This is Rietveld 408576698