Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2922233003: Remove the Allow/Block drop-down from grouped permission requests for cocoa (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Allow/Block drop-down from grouped permission requests for cocoa Grouped permission requests are being removed, except in the case of Mic/Camera. In that case, there will not be Allow/Block drop-downs for each permission requested. Instead there will be 2 individual Allow/Block buttons as in the case of single permission requests. BUG=728483 Review-Url: https://codereview.chromium.org/2922233003 Cr-Commit-Position: refs/heads/master@{#477442} Committed: https://chromium.googlesource.com/chromium/src/+/25629f4082fc2b5c990349eb98e22700f8947d70

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -253 lines) Patch
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm View 11 chunks +22 lines, -160 lines 1 comment Download
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm View 5 chunks +14 lines, -93 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
raymes
3 years, 6 months ago (2017-06-06 04:23:56 UTC) #3
tapted
lgtm - I wouldn't worry about the comment https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm File chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm (right): https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm#newcode289 chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm:289: blockButton.reset([[self ...
3 years, 6 months ago (2017-06-06 08:06:03 UTC) #7
raymes
On 2017/06/06 08:06:03, tapted wrote: > lgtm - I wouldn't worry about the comment > ...
3 years, 6 months ago (2017-06-06 22:28:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922233003/1
3 years, 6 months ago (2017-06-06 22:29:00 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 22:34:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25629f4082fc2b5c990349eb98e2...

Powered by Google App Engine
This is Rietveld 408576698