Remove the Allow/Block drop-down from grouped permission requests for cocoa

Remove the Allow/Block drop-down from grouped permission requests for cocoa

Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.

BUG=728483
Review-Url: https://codereview.chromium.org/2922233003
Cr-Commit-Position: refs/heads/master@{#477442}
Committed: https://chromium.googlesource.com/chromium/src/+/25629f4082fc2b5c990349eb98e22700f8947d70

[raymes, 2017-06-06 04:23:49]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[raymes, 2017-06-06 04:23:56]

raymes@chromium.org changed reviewers:
+ tapted@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:24:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:47:01]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-06-06 08:06:03]

lgtm - I wouldn't worry about the comment

https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/per...
File chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
(right):

https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/per...
chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm:289:
blockButton.reset([[self blockButton] retain]);
Hrm. It's weird to make this scoped_nsobject - there's no need for a retain
count to live on the stack

`NSView* blockButton = [self makeBlockButton]`

would be clearer. (addSubview will retain it internally).

I guess this is fine too though. I wouldn't worry about changing it (we'd wanna
change buttonWithTitle into something more "makeFoo" to be consistent..)

[raymes, 2017-06-06 22:28:31]

On 2017/06/06 08:06:03, tapted wrote:
> lgtm - I wouldn't worry about the comment
> 
>
https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/per...
> File chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
> (right):
> 
>
https://codereview.chromium.org/2922233003/diff/1/chrome/browser/ui/cocoa/per...
> chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm:289:
> blockButton.reset([[self blockButton] retain]);
> Hrm. It's weird to make this scoped_nsobject - there's no need for a retain
> count to live on the stack
> 
> `NSView* blockButton = [self makeBlockButton]`
> 
> would be clearer. (addSubview will retain it internally).
> 
> I guess this is fine too though. I wouldn't worry about changing it (we'd
wanna
> change buttonWithTitle into something more "makeFoo" to be consistent..)

Cool, thanks Trent! I'll leave it as-is for now.

[raymes, 2017-06-06 22:28:36]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:29:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 22:34:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496788116538700, "parent_rev":
"d9b898808fa4d2d47422efdd90fd651050c1de64", "commit_rev":
"25629f4082fc2b5c990349eb98e22700f8947d70"}

[commit-bot: I haz the power, 2017-06-06 22:34:22]

Description was changed from

==========
Remove the Allow/Block drop-down from grouped permission requests for cocoa

Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.

BUG=728483
==========

to

==========
Remove the Allow/Block drop-down from grouped permission requests for cocoa

Grouped permission requests are being removed, except in the case of
Mic/Camera. In that case, there will not be Allow/Block drop-downs for
each permission requested. Instead there will be 2 individual
Allow/Block buttons as in the case of single permission requests.

BUG=728483

Review-Url: https://codereview.chromium.org/2922233003
Cr-Commit-Position: refs/heads/master@{#477442}
Committed:
https://chromium.googlesource.com/chromium/src/+/25629f4082fc2b5c990349eb98e2...
==========

[commit-bot: I haz the power, 2017-06-06 22:34:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25629f4082fc2b5c990349eb98e2...