Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: chrome/browser/budget_service/budget_database_unittest.cc

Issue 2922203002: Always use milliseconds in the Budget API implementation (Closed)
Patch Set: missing file? Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/budget_service/budget_database_unittest.cc
diff --git a/chrome/browser/budget_service/budget_database_unittest.cc b/chrome/browser/budget_service/budget_database_unittest.cc
index 3d5bf2ac9dbd7676f3d8a70970616bf278c1ab1a..c65493ab3df4f3c439a1b01c7e491aa8da4f8a03 100644
--- a/chrome/browser/budget_service/budget_database_unittest.cc
+++ b/chrome/browser/budget_service/budget_database_unittest.cc
@@ -133,7 +133,8 @@ TEST_F(BudgetDatabaseTest, AddEngagementBudgetTest) {
ASSERT_DOUBLE_EQ(daily_budget * kDefaultExpirationInDays,
prediction_[0]->budget_at);
ASSERT_EQ(0, prediction_[1]->budget_at);
- ASSERT_EQ(expiration_time.ToDoubleT(), prediction_[1]->time);
+ ASSERT_EQ(expiration_time.ToDoubleT() * base::Time::kMillisecondsPerSecond,
+ prediction_[1]->time);
// Advance time 1 day and add more engagement budget.
clock->Advance(base::TimeDelta::FromDays(1));
@@ -145,9 +146,11 @@ TEST_F(BudgetDatabaseTest, AddEngagementBudgetTest) {
ASSERT_DOUBLE_EQ(daily_budget * (kDefaultExpirationInDays + 1),
prediction_[0]->budget_at);
ASSERT_DOUBLE_EQ(daily_budget, prediction_[1]->budget_at);
- ASSERT_EQ(expiration_time.ToDoubleT(), prediction_[1]->time);
+ ASSERT_EQ(expiration_time.ToDoubleT() * base::Time::kMillisecondsPerSecond,
+ prediction_[1]->time);
ASSERT_DOUBLE_EQ(0, prediction_[2]->budget_at);
- ASSERT_EQ((expiration_time + base::TimeDelta::FromDays(1)).ToDoubleT(),
+ ASSERT_EQ((expiration_time + base::TimeDelta::FromDays(1)).ToDoubleT() *
+ base::Time::kMillisecondsPerSecond,
prediction_[2]->time);
// Advance time by 59 minutes and check that no engagement budget is added

Powered by Google App Engine
This is Rietveld 408576698