Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2922203002: Always use milliseconds in the Budget API implementation (Closed)

Created:
3 years, 6 months ago by Peter Beverloo
Modified:
3 years, 6 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, picksi1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use milliseconds in the Budget API implementation BUG=729656 Review-Url: https://codereview.chromium.org/2922203002 Cr-Commit-Position: refs/heads/master@{#477147} Committed: https://chromium.googlesource.com/chromium/src/+/a16449269add06bf55fec1cbe3868b8fd4a806b4

Patch Set 1 #

Patch Set 2 : missing file? #

Total comments: 2

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/budget_service/budget_database.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/budget_service/budget_database_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/budget_service/budget_service_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
Peter Beverloo
3 years, 6 months ago (2017-06-05 18:34:57 UTC) #2
Miguel Garcia
lgtm
3 years, 6 months ago (2017-06-05 18:41:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922203002/20001
3 years, 6 months ago (2017-06-05 18:41:38 UTC) #10
Miguel Garcia
https://codereview.chromium.org/2922203002/diff/20001/chrome/browser/budget_service/budget_database.cc File chrome/browser/budget_service/budget_database.cc (right): https://codereview.chromium.org/2922203002/diff/20001/chrome/browser/budget_service/budget_database.cc#newcode160 chrome/browser/budget_service/budget_database.cc:160: clock_->Now().ToDoubleT() * base::Time::kMillisecondsPerSecond; Why not simply clock_->Now().InMilliseconds() (or clock_->Now().InMilliseconds() ...
3 years, 6 months ago (2017-06-05 18:47:10 UTC) #12
Peter Beverloo
https://codereview.chromium.org/2922203002/diff/20001/chrome/browser/budget_service/budget_database.cc File chrome/browser/budget_service/budget_database.cc (right): https://codereview.chromium.org/2922203002/diff/20001/chrome/browser/budget_service/budget_database.cc#newcode160 chrome/browser/budget_service/budget_database.cc:160: clock_->Now().ToDoubleT() * base::Time::kMillisecondsPerSecond; On 2017/06/05 18:47:10, Miguel Garcia wrote: ...
3 years, 6 months ago (2017-06-05 19:01:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922203002/40001
3 years, 6 months ago (2017-06-05 19:01:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310623)
3 years, 6 months ago (2017-06-05 22:36:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922203002/40001
3 years, 6 months ago (2017-06-05 23:20:41 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 01:34:16 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a16449269add06bf55fec1cbe386...

Powered by Google App Engine
This is Rietveld 408576698