Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2922193002: Change hover element to HTML element when over root scrollbar (Closed)

Created:
3 years, 6 months ago by chaopeng
Modified:
3 years, 6 months ago
Reviewers:
bokan
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change hover element to HTML element when over root scrollbar We previously set hover element to document when over root scrollbar. In this patch we change it to HTML element. BUG=729140 Review-Url: https://codereview.chromium.org/2922193002 Cr-Commit-Position: refs/heads/master@{#477728} Committed: https://chromium.googlesource.com/chromium/src/+/13ecf25f878437df5e233a1f9e567aff56324aec

Patch Set 1 #

Total comments: 2

Patch Set 2 : bokan comments addressed #

Patch Set 3 : rebaseline layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 4 chunks +39 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/hover-root-scrollbar.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
chaopeng
PTAL. Thank you.
3 years, 6 months ago (2017-06-05 18:30:54 UTC) #2
bokan
sorry for the delay, lgtm https://codereview.chromium.org/2922193002/diff/1/third_party/WebKit/Source/core/layout/LayoutView.cpp File third_party/WebKit/Source/core/layout/LayoutView.cpp (right): https://codereview.chromium.org/2922193002/diff/1/third_party/WebKit/Source/core/layout/LayoutView.cpp#newcode168 third_party/WebKit/Source/core/layout/LayoutView.cpp:168: // If scrollbar belong's ...
3 years, 6 months ago (2017-06-06 21:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922193002/20001
3 years, 6 months ago (2017-06-06 22:25:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/462330)
3 years, 6 months ago (2017-06-07 00:42:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922193002/40001
3 years, 6 months ago (2017-06-07 16:27:50 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 19:35:36 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13ecf25f878437df5e233a1f9e56...

Powered by Google App Engine
This is Rietveld 408576698