third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: changes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits/AuditController.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

index 3831e39dca6d283cbbcb7d21d8cca694e1c8d25c..fc944f399e5af24033b0bb280136bdcc6f696a89 100644

--- a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

@@ -427,8 +427,8 @@ ConsoleModel.ConsoleMessage = class {

this.scriptId = scriptId || null;

this.workerId = workerId || null;

- var networkManager = (runtimeModel && requestId) ? runtimeModel.target().model(SDK.NetworkManager) : null;

- this.request = (networkManager && requestId) ? NetworkLog.networkLog.requestForId(networkManager, requestId) : null;

+ var manager = runtimeModel ? runtimeModel.target().model(SDK.NetworkManager) : null;

dgozman 2017/06/06 20:54:40 nit: what was the point of renaming the variable?

allada 2017/06/08 00:42:06 It was just so I could fit the line below on one l

+ this.request = (manager && requestId) ? NetworkLog.networkLog.requestByManagerAndId(manager, requestId) : null;

if (this.request) {

var initiator = this.request.initiator();