third_party/WebKit/Source/devtools/front_end/audits/AuditController.js - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: changes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html ('k') | third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

index 1771d4cd1becbdf2b5776e02c654165ed8ebc4c1..6248249b71fc2bac085d89e4a12622e68125a7a3 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

@@ -72,7 +72,9 @@ Audits.AuditController = class {

}

var networkManager = target.model(SDK.NetworkManager);

- var requests = networkManager ? NetworkLog.networkLog.requestsForManager(networkManager).slice() : [];

+ var requests = NetworkLog.networkLog.requests().filter(

+ request => SDK.NetworkManager.managerForRequest(request) === networkManager);

var compositeProgress = new Common.CompositeProgress(this._progress);

var subprogresses = [];

for (var i = 0; i < categories.length; ++i)