client/utils/net.py - Issue 2921943002: Fix GS URL regex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/utils/net.py

Issue 2921943002: Fix GS URL regex (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/utils/net.py

diff --git a/client/utils/net.py b/client/utils/net.py

index 7eaeb878035db1fd8debcea78165836df41a68b2..faccca93e7061cd5963d7bc44657a87417f6eee6 100644

--- a/client/utils/net.py

+++ b/client/utils/net.py

@@ -69,7 +69,7 @@ CONTENT_ENCODERS = {

# Google Storage URL regular expression.

-GS_STORAGE_HOST_URL_RE = re.compile(r'https://.*\.storage\.googleapis\.com')

+GS_STORAGE_HOST_URL_RE = re.compile(r'https://(.*\.)?storage\.googleapis\.com')

M-A Ruel 2017/06/02 17:26:23 It should be a + instead of a *, then lgtm

nodir 2017/06/02 17:28:03 Done.

# Global (for now) map: server URL (http://example.com) -> HttpService instance.

# Used by get_http_service to cache HttpService instances.

« no previous file with comments | « no previous file | no next file » | no next file with comments »