Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 2921923002: Remove chrome://flag enable-pointer-events (Closed)

Created:
3 years, 6 months ago by eirage
Modified:
3 years, 6 months ago
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, eae+blinkwatch, sof, jam, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, Navid Zolghadr, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome://flag enable-pointer-events Remove Pointer Event flag because it was added in Chrome 55. This feature will not be unship. It's safe to remove. BUG=687976 Review-Url: https://codereview.chromium.org/2921923002 Cr-Commit-Position: refs/heads/master@{#477961} Committed: https://chromium.googlesource.com/chromium/src/+/0378b3560726088bb24b5ae81bef3f94753855f0

Patch Set 1 #

Patch Set 2 : remove pointer_event flag from testing_config.json #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -63 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebRuntimeFeatures.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 33 (21 generated)
eirage
3 years, 6 months ago (2017-06-02 15:58:21 UTC) #4
dtapuska
On 2017/06/02 15:58:21, eirage wrote: please remove it from https://cs.chromium.org/chromium/src/testing/variations/fieldtrial_testing_config.json?dr=C as well.
3 years, 6 months ago (2017-06-02 16:32:27 UTC) #5
eirage
ptal
3 years, 6 months ago (2017-06-02 19:20:42 UTC) #8
dtapuska
On 2017/06/02 19:20:42, eirage wrote: > ptal lgtm. Perhaps you can indicate in the CL ...
3 years, 6 months ago (2017-06-02 19:23:46 UTC) #9
Navid Zolghadr
lgtm
3 years, 6 months ago (2017-06-05 14:30:59 UTC) #16
eirage
rkaplow@chromium.org: Please review changes in testing/* creis@chromium.org: Please review changes in content/* rbyers@chromium.org: Please review ...
3 years, 6 months ago (2017-06-05 17:59:15 UTC) #18
Charlie Reis
LGTM
3 years, 6 months ago (2017-06-05 18:20:22 UTC) #19
rkaplow
lgtm
3 years, 6 months ago (2017-06-05 21:00:25 UTC) #20
Rick Byers
Thanks for the cleanup, LGTM Minor typo on the CL description: "It's save to remove." ...
3 years, 6 months ago (2017-06-07 18:04:34 UTC) #21
eirage
On 2017/06/07 18:04:34, Rick Byers wrote: > Thanks for the cleanup, LGTM > > Minor ...
3 years, 6 months ago (2017-06-07 18:11:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921923002/40001
3 years, 6 months ago (2017-06-08 13:17:38 UTC) #30
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 14:34:24 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0378b3560726088bb24b5ae81bef...

Powered by Google App Engine
This is Rietveld 408576698