Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2921913002: Remove an unnecessary TODO from PropertyGet type inference. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-02 12:37:49 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-02 12:39:01 UTC) #3
scheglov
LGTM
3 years, 6 months ago (2017-06-02 15:26:59 UTC) #4
Paul Berry
3 years, 6 months ago (2017-06-02 15:57:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
506389a74490341d95f23cf8b45dc99deabedfe1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698