Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2921913002: Remove an unnecessary TODO from PropertyGet type inference. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index 14b197551c8ea844afaf850698dac5eb6be81f12..ecb416250fc483fdcc6a842fb2ffb9c80171a58c 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -1141,7 +1141,11 @@ class KernelPropertyGet extends PropertyGet implements KernelExpression {
// - The inference dependency of the identifier is the referent if the
// referent is a candidate for inference. Otherwise there are no
// inference dependencies.
- // TODO(paulberry): implement the proper logic here.
+
+ // For a property get, the only things we could be looking at are an
+ // instance field, an instance getter, or an instance method. For the first
+ // two, we disallow them in [_inferExpression]. For the last, there are no
+ // field dependencies. So we don't need to do anything here.
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698