Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2921863002: Introduce range-based for loop in LayoutSelection. (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce range-based for loop in LayoutSelection. LayoutSelection traverses Layout tree in the way here and there. This CL introduces LayoutSelection::Iterator which lists only 'valid' LayoutObjects( see SelectionPaintRange::Iterator::operator++); BUG=708453 Review-Url: https://codereview.chromium.org/2921863002 Cr-Commit-Position: refs/heads/master@{#478562} Committed: https://chromium.googlesource.com/chromium/src/+/0a7a89f4a4f300968dd600ad428a45b01541e3e0

Patch Set 1 #

Total comments: 10

Patch Set 2 : update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -48 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 1 7 chunks +52 lines, -48 lines 2 comments Download

Messages

Total messages: 20 (12 generated)
yoichio
3 years, 6 months ago (2017-06-02 07:06:53 UTC) #5
yosin_UTC9
https://codereview.chromium.org/2921863002/diff/1/third_party/WebKit/Source/core/editing/LayoutSelection.cpp File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2921863002/diff/1/third_party/WebKit/Source/core/editing/LayoutSelection.cpp#newcode85 third_party/WebKit/Source/core/editing/LayoutSelection.cpp:85: if (!stop_) nit: prefer early-retrun if (stop_) return; stop_ ...
3 years, 6 months ago (2017-06-02 08:35:44 UTC) #8
yoichio
https://codereview.chromium.org/2921863002/diff/1/third_party/WebKit/Source/core/editing/LayoutSelection.cpp File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2921863002/diff/1/third_party/WebKit/Source/core/editing/LayoutSelection.cpp#newcode85 third_party/WebKit/Source/core/editing/LayoutSelection.cpp:85: if (!stop_) On 2017/06/02 08:35:44, yosin_UTC9 wrote: > nit: ...
3 years, 6 months ago (2017-06-12 06:12:52 UTC) #11
yosin_UTC9
https://codereview.chromium.org/2921863002/diff/20001/third_party/WebKit/Source/core/editing/LayoutSelection.cpp File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2921863002/diff/20001/third_party/WebKit/Source/core/editing/LayoutSelection.cpp#newcode437 third_party/WebKit/Source/core/editing/LayoutSelection.cpp:437: while (cb && !cb->IsLayoutView()) { Let's use for-statement. s/cb/block/ ...
3 years, 6 months ago (2017-06-12 06:37:36 UTC) #12
yoichio
https://codereview.chromium.org/2921863002/diff/20001/third_party/WebKit/Source/core/editing/LayoutSelection.cpp File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2921863002/diff/20001/third_party/WebKit/Source/core/editing/LayoutSelection.cpp#newcode437 third_party/WebKit/Source/core/editing/LayoutSelection.cpp:437: while (cb && !cb->IsLayoutView()) { I will use CollectSelectedMap ...
3 years, 6 months ago (2017-06-12 06:45:44 UTC) #13
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-12 06:55:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921863002/20001
3 years, 6 months ago (2017-06-12 06:55:42 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 07:47:00 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a7a89f4a4f300968dd600ad428a...

Powered by Google App Engine
This is Rietveld 408576698