Add UseCounter features for cursor values -webkit-zoom-in/out

Add UseCounter features for cursor values -webkit-zoom-in/out

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174683

[philipj_slow, 2014-05-22 20:44:17]

Julien, this is how I thought the use counter would be added. Continuing the
discussion from https://codereview.chromium.org/288303007/ is there any kind of
aliasing you think would work together with this?

[Julien - ping for review, 2014-05-23 09:47:35]

> is there any kind of aliasing you think would work together with this?

I looked at our options and it seems that it would require quite some work to
get any aliasing that would fit our needs (currently both properties and values
are hardcoded into an array for fast parsing). That's why I think we should just
roll with what we have for now. LGTM

https://codereview.chromium.org/292183009/diff/20001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/292183009/diff/20001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:674:
m_context.useCounter()->count(UseCounter::PrefixedCursorZoomOut);
Ideally we would want to send a deprecation message but IIRC this was hard to do
without having to touch the whole parsing logic as we need an extra argument
(Document / DOMWindow or ExecutionContext).

[philipj_slow, 2014-05-23 10:50:45]

Thanks Julien!

https://codereview.chromium.org/292183009/diff/20001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/292183009/diff/20001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:674:
m_context.useCounter()->count(UseCounter::PrefixedCursorZoomOut);
On 2014/05/23 09:47:35, Julien Chaffraix - CET wrote:
> Ideally we would want to send a deprecation message but IIRC this was hard to
do
> without having to touch the whole parsing logic as we need an extra argument
> (Document / DOMWindow or ExecutionContext).

Oh, hadn't noticed that countDeprecation is going to require an extra argument.
With some luck the usage will be so low that direct removal is possible,
otherwise we'll have to figure something out when deprecating this in a few
months time.

[philipj_slow, 2014-05-23 10:51:06]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-05-23 10:51:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/292183009/20001

[commit-bot: I haz the power, 2014-05-23 11:25:36]

Change committed as 174683