Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 292183009: Add UseCounter features for cursor values -webkit-zoom-in/out (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 if (!list) 660 if (!list)
661 list = CSSValueList::createCommaSeparated(); 661 list = CSSValueList::createCommaSeparated();
662 662
663 if (image) 663 if (image)
664 list->append(CSSCursorImageValue::create(image, hasHotSpot, hotS pot)); 664 list->append(CSSCursorImageValue::create(image, hasHotSpot, hotS pot));
665 665
666 if (!value || !(value->unit == CSSParserValue::Operator && value->iV alue == ',')) 666 if (!value || !(value->unit == CSSParserValue::Operator && value->iV alue == ','))
667 return false; 667 return false;
668 value = m_valueList->next(); // comma 668 value = m_valueList->next(); // comma
669 } 669 }
670 if (value && m_context.useCounter()) {
671 if (value->id == CSSValueWebkitZoomIn)
672 m_context.useCounter()->count(UseCounter::PrefixedCursorZoomIn);
673 else if (value->id == CSSValueWebkitZoomOut)
674 m_context.useCounter()->count(UseCounter::PrefixedCursorZoomOut) ;
Julien - ping for review 2014/05/23 09:47:35 Ideally we would want to send a deprecation messag
philipj_slow 2014/05/23 10:50:46 Oh, hadn't noticed that countDeprecation is going
675 }
670 if (list) { 676 if (list) {
671 if (!value) 677 if (!value)
672 return false; 678 return false;
673 if (inQuirksMode() && value->id == CSSValueHand) // MSIE 5 compatibi lity :/ 679 if (inQuirksMode() && value->id == CSSValueHand) // MSIE 5 compatibi lity :/
674 list->append(cssValuePool().createIdentifierValue(CSSValuePointe r)); 680 list->append(cssValuePool().createIdentifierValue(CSSValuePointe r));
675 else if ((value->id >= CSSValueAuto && value->id <= CSSValueWebkitZo omOut) || value->id == CSSValueCopy || value->id == CSSValueNone) 681 else if ((value->id >= CSSValueAuto && value->id <= CSSValueWebkitZo omOut) || value->id == CSSValueCopy || value->id == CSSValueNone)
676 list->append(cssValuePool().createIdentifierValue(value->id)); 682 list->append(cssValuePool().createIdentifierValue(value->id));
677 m_valueList->next(); 683 m_valueList->next();
678 parsedValue = list.release(); 684 parsedValue = list.release();
679 break; 685 break;
(...skipping 7826 matching lines...) Expand 10 before | Expand all | Expand 10 after
8506 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill)); 8512 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
8507 if (!seenStroke) 8513 if (!seenStroke)
8508 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) ); 8514 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) );
8509 if (!seenMarkers) 8515 if (!seenMarkers)
8510 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers )); 8516 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers ));
8511 8517
8512 return parsedValues.release(); 8518 return parsedValues.release();
8513 } 8519 }
8514 8520
8515 } // namespace WebCore 8521 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698