Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 292183006: Java bridge relax case requirement on "inf" and "nan". (Closed)

Created:
6 years, 7 months ago by Anton
Modified:
6 years, 7 months ago
Reviewers:
Ted C, jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Java bridge relax case requirement on "inf" and "nan". Needed for 64-bit which is using a newer version of the runtime. Prior to this CL the test requires that Infinity is converted to the string "Inf" and NaN is converted to the string "NaN". However, these conversions are done by a format %g option which is defined as providing a lower case string (http://en.wikipedia.org/wiki/Printf_format_string). As LiveConnect provides "no guarantee" as to number formatting (https://jdk6.java.net/plugin2/liveconnect/#JS_NUMBER_VALUE) it seems best to just relax these tests. BUG=346626, 354405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anton
6 years, 7 months ago (2014-05-21 16:47:57 UTC) #1
jdduke (slow)
This lgtm, but I'm really only an owner for input-related code, so please wait for ...
6 years, 7 months ago (2014-05-21 17:14:04 UTC) #2
Ted C
lgtm
6 years, 7 months ago (2014-05-21 17:39:56 UTC) #3
Anton
The CQ bit was checked by anton@chromium.org
6 years, 7 months ago (2014-05-22 09:48:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/292183006/1
6 years, 7 months ago (2014-05-22 09:49:42 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 17:53:29 UTC) #6
Message was sent while issue was closed.
Change committed as 272229

Powered by Google App Engine
This is Rietveld 408576698