content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java - Issue 292183006: Java bridge relax case requirement on "inf" and "nan".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

Issue 292183006: Java bridge relax case requirement on "inf" and "nan". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

index 603588626d65f613db1a43e8c7ef1ffc62a8568e..c344416500f085d9825270f7e1af5768c37c290a 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

@@ -312,7 +312,7 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {

assertNull(mTestObject.waitForObjectValue());

executeJavaScript("testObject.setStringValue(Number.NaN);");

- assertEquals("NaN", mTestObject.waitForStringValue());

+ assertTrue("nan".equalsIgnoreCase(mTestObject.waitForStringValue()));

executeJavaScript("testObject.setBooleanValue(Number.NaN);");

assertFalse(mTestObject.waitForBooleanValue());

@@ -353,7 +353,7 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {

assertNull(mTestObject.waitForObjectValue());

executeJavaScript("testObject.setStringValue(Infinity);");

- assertEquals("Inf", mTestObject.waitForStringValue());

+ assertTrue("inf".equalsIgnoreCase(mTestObject.waitForStringValue()));

executeJavaScript("testObject.setBooleanValue(Infinity);");

assertFalse(mTestObject.waitForBooleanValue());

« no previous file with comments | « no previous file | no next file » | no next file with comments »