Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp

Issue 2921823002: Rationalize WakeLock naming conventions (Closed)
Patch Set: fix Mac compile error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp b/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
index 73ee0296282dde322d798702e6fae273759d3e4e..5ec5b6096db1da94ea14343323d50b317385b340 100644
--- a/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
@@ -24,8 +24,8 @@
namespace blink {
namespace {
-using device::mojom::blink::WakeLockService;
-using device::mojom::blink::WakeLockServiceRequest;
+using device::mojom::blink::WakeLock;
+using device::mojom::blink::WakeLockRequest;
// This class allows binding interface requests to a MockWakeLockService.
class MockInterfaceProvider : public InterfaceProvider {
@@ -40,22 +40,21 @@ class MockInterfaceProvider : public InterfaceProvider {
private:
// A mock WakeLockService used to intercept calls to the mojo methods.
- class MockWakeLockService : public WakeLockService {
+ class MockWakeLockService : public WakeLock {
public:
MockWakeLockService(MockInterfaceProvider* registry,
- WakeLockServiceRequest request)
+ WakeLockRequest request)
: binding_(this, std::move(request)), registry_(registry) {}
~MockWakeLockService() {}
private:
- // mojom::WakeLockService
+ // mojom::WakeLock
void RequestWakeLock() override { registry_->SetWakeLockStatus(true); }
void CancelWakeLock() override { registry_->SetWakeLockStatus(false); }
- void AddClient(
- device::mojom::blink::WakeLockServiceRequest wake_lock) override {}
+ void AddClient(device::mojom::blink::WakeLockRequest wake_lock) override {}
void HasWakeLockForTests(HasWakeLockForTestsCallback callback) override {}
- mojo::Binding<WakeLockService> binding_;
+ mojo::Binding<WakeLock> binding_;
MockInterfaceProvider* const registry_;
};
std::unique_ptr<MockWakeLockService> mock_wake_lock_service_;
@@ -66,7 +65,7 @@ class MockInterfaceProvider : public InterfaceProvider {
void MockInterfaceProvider::GetInterface(const char* name,
mojo::ScopedMessagePipeHandle handle) {
mock_wake_lock_service_.reset(
- new MockWakeLockService(this, WakeLockServiceRequest(std::move(handle))));
+ new MockWakeLockService(this, WakeLockRequest(std::move(handle))));
}
// A TestWebFrameClient to allow overriding the interfaceProvider() with a mock.

Powered by Google App Engine
This is Rietveld 408576698