Removes unnecessary subclassing of BookmarkCollectionView.

Removes unnecessary subclassing of BookmarkCollectionView.

In the current code BookmarkCollectionView is only subclassed by
BookmarkFolderCollectionView. This hierarchy of classes is redundant
in the current scenario. The inheritance was introduced in legacy code,
when there were more than one subclass.

See go/bookmarks-refactor for more details.

BUG=705339
Review-Url: https://codereview.chromium.org/2921813002
Cr-Commit-Position: refs/heads/master@{#478941}
Committed: https://chromium.googlesource.com/chromium/src/+/6387c0e96147f491c7417ecbad7b1f79f6e32336

[ramyasharma, 2017-06-06 04:32:06]

The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 04:32:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 05:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 05:59:33]

Dry run: This issue passed the CQ dry run.

[ramyasharma, 2017-06-06 07:11:06]

ramyasharma@chromium.org changed reviewers:
+ noyau@chromium.org

[ramyasharma, 2017-06-06 07:11:06]

Hi Eric,

PTAL?

Thanks,
Ramya

[ramyasharma, 2017-06-06 07:11:17]

The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 07:11:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 09:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 09:20:17]

Dry run: This issue passed the CQ dry run.

[ramyasharma, 2017-06-09 04:25:45]

Description was changed from

==========
Removes unnecessary subclassing of BookmarkCollectionView.

In the current code BookmarkCollectionView is only subclassed by
BookmarkFolderCollectionView. This hierarchy of classes is redundant
in the current scenario. The inheritance was introduced in legacy code,
when there were more than one subclass.

BUG=705339
==========

to

==========
Removes unnecessary subclassing of BookmarkCollectionView.

In the current code BookmarkCollectionView is only subclassed by
BookmarkFolderCollectionView. This hierarchy of classes is redundant
in the current scenario. The inheritance was introduced in legacy code,
when there were more than one subclass.

See go/bookmarks-refactor for more details.

BUG=705339
==========

[noyau (Ping after 24h), 2017-06-12 08:28:26]

lgtm.

Just a nit: I would have kept BookmarkCollection instead of
BookmarkFolderCollection as the class name.

[ramyasharma, 2017-06-13 04:26:46]

Patchset #3 (id:40001) has been deleted

[ramyasharma, 2017-06-13 04:26:53]

Patchset #3 (id:60001) has been deleted

[ramyasharma, 2017-06-13 04:29:31]

The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 04:29:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramyasharma, 2017-06-13 04:43:01]

On 2017/06/12 08:28:26, noyau (Ping after 24h) wrote:
> lgtm.
> 
> Just a nit: I would have kept BookmarkCollection instead of
> BookmarkFolderCollection as the class name.

Done. Thanks for the review.

[commit-bot: I haz the power, 2017-06-13 06:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 06:39:54]

Dry run: This issue passed the CQ dry run.

[ramyasharma, 2017-06-13 07:43:06]

The CQ bit was checked by ramyasharma@chromium.org

[ramyasharma, 2017-06-13 07:43:07]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/2921813002/#ps100001
(title: "")

[commit-bot: I haz the power, 2017-06-13 07:43:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 08:58:28]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497339786902230,
"parent_rev": "89bcae17f54dc20a06d75e6c8b409d4423fabed1", "commit_rev":
"6387c0e96147f491c7417ecbad7b1f79f6e32336"}

[commit-bot: I haz the power, 2017-06-13 08:58:37]

Description was changed from

==========
Removes unnecessary subclassing of BookmarkCollectionView.

In the current code BookmarkCollectionView is only subclassed by
BookmarkFolderCollectionView. This hierarchy of classes is redundant
in the current scenario. The inheritance was introduced in legacy code,
when there were more than one subclass.

See go/bookmarks-refactor for more details.

BUG=705339
==========

to

==========
Removes unnecessary subclassing of BookmarkCollectionView.

In the current code BookmarkCollectionView is only subclassed by
BookmarkFolderCollectionView. This hierarchy of classes is redundant
in the current scenario. The inheritance was introduced in legacy code,
when there were more than one subclass.

See go/bookmarks-refactor for more details.

BUG=705339

Review-Url: https://codereview.chromium.org/2921813002
Cr-Commit-Position: refs/heads/master@{#478941}
Committed:
https://chromium.googlesource.com/chromium/src/+/6387c0e96147f491c7417ecbad7b...
==========

[commit-bot: I haz the power, 2017-06-13 08:58:39]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6387c0e96147f491c7417ecbad7b...