Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2921803002: [EasyUnlock] Force a device sync after turning off the feature. (Closed)

Created:
3 years, 6 months ago by Tim Song
Modified:
3 years, 6 months ago
Reviewers:
sacomoto
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Force a device sync after turning off the feature. BUG=728784, 728432 Review-Url: https://codereview.chromium.org/2921803002 Cr-Commit-Position: refs/heads/master@{#476758} Committed: https://chromium.googlesource.com/chromium/src/+/5ff3e973ae76550542d100b0714515bb72be3f91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tim Song
3 years, 6 months ago (2017-06-02 00:26:44 UTC) #2
sacomoto
LGTM. I remember hitting 728784 when I was implementing the setup.
3 years, 6 months ago (2017-06-02 14:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921803002/1
3 years, 6 months ago (2017-06-02 18:42:16 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:45:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ff3e973ae76550542d100b07145...

Powered by Google App Engine
This is Rietveld 408576698