[Offline Prefetch] Pass api key to offline prefetch requests

[Offline Prefetch] Pass api key to offline prefetch requests

BUG=717305
TEST=tests updated

Review-Url: https://codereview.chromium.org/2921783002
Cr-Commit-Position: refs/heads/master@{#477393}
Committed: https://chromium.googlesource.com/chromium/src/+/a4aab113db5e8150b07424daffab59a42d82f917

[jianli, 2017-06-01 23:08:30]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[jianli, 2017-06-01 23:08:35]

jianli@chromium.org changed reviewers:
+ dewittj@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:09:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:13:02]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jianli, 2017-06-02 00:55:02]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 00:56:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 02:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 02:49:43]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-06-02 16:32:33]

in general this seems okay, but to me it seems strange to leak the channel
information into the request fetcher.  Can we just inject the necessary API key
directly?

https://codereview.chromium.org/2921783002/diff/20001/components/offline_page...
File components/offline_pages/core/prefetch/DEPS (right):

https://codereview.chromium.org/2921783002/diff/20001/components/offline_page...
components/offline_pages/core/prefetch/DEPS:2: "+google_apis",
Do we also need +version_info?

[jianli, 2017-06-02 18:53:09]

We usually choose to pass channel info from browser layer to component layer, as
in many other features. I think we should get the api key on the fly.

https://codereview.chromium.org/2921783002/diff/20001/components/offline_page...
File components/offline_pages/core/prefetch/DEPS (right):

https://codereview.chromium.org/2921783002/diff/20001/components/offline_page...
components/offline_pages/core/prefetch/DEPS:2: "+google_apis",
On 2017/06/02 16:32:32, dewittj wrote:
> Do we also need +version_info?

It is already included in upper level DEPS.

[dewittj, 2017-06-02 19:02:26]

lgtm.

One nit is that there is no test at the prefetch_request_fetcher level that the
proper query parameters are set.  But it doesn't look like there are any tests
to that effect at that layer yet, so could leave that for later.

[jianli, 2017-06-02 19:05:44]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-06-02 19:06:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 19:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 19:16:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2017-06-02 20:39:22]

jianli@chromium.org changed reviewers:
+ rogerta@chromium.org

[jianli, 2017-06-02 20:39:24]

rogerta for google_apis dependency

[Roger Tawa OOO till Jul 10th, 2017-06-05 20:58:26]

lgtm for google_apis deps

[jianli, 2017-06-05 20:58:57]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-06-05 20:59:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 22:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 22:54:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jianli, 2017-06-05 23:12:26]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:13:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 01:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 01:39:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jianli, 2017-06-06 19:34:33]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-06-06 19:34:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 20:36:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496777673795970,
"parent_rev": "0add335f1a4952e84d7a491cbdc0bc2d557206c7", "commit_rev":
"8e945e4be35e5968e2d4b76ec08db169e4c35ab6"}

[commit-bot: I haz the power, 2017-06-06 20:37:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496777673795970,
"parent_rev": "84670c9d1778d069499d138b364dac521c5e389c", "commit_rev":
"a4aab113db5e8150b07424daffab59a42d82f917"}

[commit-bot: I haz the power, 2017-06-06 20:37:10]

Description was changed from

==========
[Offline Prefetch] Pass api key to offline prefetch requests

BUG=717305
TEST=tests updated
==========

to

==========
[Offline Prefetch] Pass api key to offline prefetch requests

BUG=717305
TEST=tests updated

Review-Url: https://codereview.chromium.org/2921783002
Cr-Commit-Position: refs/heads/master@{#477393}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4aab113db5e8150b07424daffab...
==========

[commit-bot: I haz the power, 2017-06-06 20:37:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4aab113db5e8150b07424daffab...