Issue 2921763002: Make test version of forEachTest() return a future.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2921763002: Make test version of forEachTest() return a future. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Make test version of forEachTest() return a future. Making it async seemed like the natural way to do it. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/e091fbf82af0e017255f22a1c72cde354f8e77d4

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/standalone/io/test_runner_test.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

This addresses your comment in: https://codereview.chromium.org/2907403005/ Thanks!

3 years, 6 months ago (2017-06-01 22:55:42 UTC) #2

Bob Nystrom

3 years, 6 months ago (2017-06-01 23:08:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e091fbf82af0e017255f22a1c72cde354f8e77d4 (presubmit successful).