Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tests/standalone/io/test_runner_test.dart

Issue 2921763002: Make test version of forEachTest() return a future. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/test_runner_test.dart
diff --git a/tests/standalone/io/test_runner_test.dart b/tests/standalone/io/test_runner_test.dart
index 12fcae91113e9d11c5155d9ffe592ea008ae2d7a..ecbbe6118e5b9da235fea98fb4d30994a924d437 100644
--- a/tests/standalone/io/test_runner_test.dart
+++ b/tests/standalone/io/test_runner_test.dart
@@ -69,7 +69,7 @@ class CustomTestSuite extends TestSuite {
CustomTestSuite(Configuration configuration)
: super(configuration, "CustomTestSuite");
- Future forEachTest(TestCaseEvent onTest, Map testCache, [onDone]) {
+ Future forEachTest(TestCaseEvent onTest, Map testCache, [onDone]) async {
void enqueueTestCase(testCase) {
TestController.numTests++;
onTest(testCase);
@@ -91,8 +91,6 @@ class CustomTestSuite extends TestSuite {
if (onDone != null) {
onDone();
}
-
- return null;
}
TestCase _makeNormalTestCase(name, expectations) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698