Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: content/browser/frame_host/navigator.h

Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.
Patch Set: Adding setSelfAsOpener parameter. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/windows.json ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 424d828c204c6536b76f0e2373b3797023061b82..2d92adb4d6c974f2ed2f66022a2f68be16e630c5 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -53,12 +53,12 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
RenderFrameHostImpl* render_frame_host,
const GURL& url,
const std::vector<GURL>& redirect_chain,
- const base::TimeTicks& navigation_start) {};
+ const base::TimeTicks& navigation_start) {}
// The RenderFrameHostImpl has failed a provisional load.
virtual void DidFailProvisionalLoadWithError(
RenderFrameHostImpl* render_frame_host,
- const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {};
+ const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {}
// The RenderFrameHostImpl has failed to load the document.
virtual void DidFailLoadWithError(
@@ -121,7 +121,6 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
const std::string& extra_headers,
const Referrer& referrer,
WindowOpenDisposition disposition,
- bool force_new_process_for_new_contents,
bool should_replace_current_entry,
bool user_gesture) {}
@@ -176,8 +175,8 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// TODO(carlosk): once PlzNavigate is the only navigation implementation
// remove the URL parameter and rename this method to better suit its naming
// conventions.
- virtual void LogResourceRequestTime(
- base::TimeTicks timestamp, const GURL& url) {};
+ virtual void LogResourceRequestTime(base::TimeTicks timestamp,
+ const GURL& url) {}
// Called to record the time it took to execute the before unload hook for the
// current navigation.
« no previous file with comments | « chrome/common/extensions/api/windows.json ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698