chrome/common/extensions/api/windows.json - Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/windows.json

Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.

Patch Set: Adding setSelfAsOpener parameter. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/windows.json

diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json

index 0e8af54caecd527552ece2be989daf2c937948b9..b21adb554eda7d1f220a7c52bfbaaaf85c4d55cf 100644

--- a/chrome/common/extensions/api/windows.json

+++ b/chrome/common/extensions/api/windows.json

@@ -224,7 +224,8 @@

"$ref": "WindowState",

"optional": true,

"description": "The initial state of the window. The 'minimized', 'maximized' and 'fullscreen' states cannot be combined with 'left', 'top', 'width' or 'height'."

- }

+ },

+ "setSelfAsOpener": {"type": "boolean", "optional": true, "description": "Whether the newly opened window will be in the same unit of related browsing contexts [1], having its window.opener set to the caller and otherwise behaving similarily to window.open. [1] - https://www.w3.org/TR/html51/browsers.html#unit-of-related-browsing-contexts"}

"optional": true

« no previous file with comments | « chrome/browser/ui/browser_navigator_params.cc ('k') | content/browser/frame_host/navigator.h » ('j') | no next file with comments »